Bug 248590 – AX: Make crash-in-element-for-text-marker.html and aria-liveregions-attributes.html async-friendly so they can pass in ITM

• Component: Accessibility
• Status: RESOLVED FIXED

[Tyler Wilcock]

AX: Make crash-in-element-for-text-marker.html and aria-liveregions-attributes.html async-friendly so they can pass in ITM

[Radar WebKit Bug Importer]

<rdar://problem/102849570>

[Tyler Wilcock]

Created attachment 463826 [details]
Patch

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #2)
> Created attachment 463826 [details]
> Patch

--- a/LayoutTests/resources/accessibility-helper.js
+++ b/LayoutTests/resources/accessibility-helper.js
@@ -177,6 +177,11 @@ async function expectAsyncExpression(expression, expectedValue) {
     debug(`PASS ${evalExpression}`);
 }

+async function waitForFocus(id) {
+    document.getElementById(id).focus();
+    await waitFor(() => accessibilityController.focusedElement && accessibilityController.focusedElement.domIdentifier === id);
+}

Would it be a bit more performant if we don't call accessibilityController.focusedElement twice? This may be called a bunch of times like in the first test in this patch.

[Tyler Wilcock]

Created attachment 463837 [details]
Patch

[EWS]

Committed 257319@main (fb7087c033ee): <https://commits.webkit.org/257319@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463837 [details].