Bug 24856

Summary: run-javascriptcore-tests should run testapi on Windows
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Bug Depends on: 24857    
Bug Blocks:    
Attachments:
Description Flags
copy testapi.js to $WebKitOutputDir
none
patch to enable testapi on Windows
none
Fix Bug 24856: run-javascriptcore-tests should run testapi on Windows mrowe: review+

Adam Roben (:aroben)
Reported 2009-03-26 14:16:27 PDT
Currently, run-javascriptcore-tests only runs testapi on Mac. It should run it on Windows, too!
Attachments
copy testapi.js to $WebKitOutputDir (3.26 KB, patch)
2009-03-26 14:17 PDT, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
patch to enable testapi on Windows (2.50 KB, patch)
2009-03-26 14:26 PDT, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
Fix Bug 24856: run-javascriptcore-tests should run testapi on Windows (1.13 KB, patch)
2009-08-13 08:23 PDT, Adam Roben (:aroben) 		mrowe: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2009-03-26 14:17:29 PDT
Created attachment 28986 [details] copy testapi.js to $WebKitOutputDir
Adam Roben (:aroben)
Comment 2 2009-03-26 14:26:25 PDT
Created attachment 28988 [details] patch to enable testapi on Windows We can't land this patch until bug 24857 is fixed, so not marking for review yet.
Adam Roben (:aroben)
Comment 3 2009-03-26 14:28:39 PDT
Comment on attachment 28986 [details] copy testapi.js to $WebKitOutputDir Landed as r42016
Adam Roben (:aroben)
Comment 4 2009-08-13 08:23:28 PDT
Created attachment 34743 [details] Fix Bug 24856: run-javascriptcore-tests should run testapi on Windows <https://bugs.webkit.org/show_bug.cgi?id=24856> Reviewed by NOBODY (OOPS!). * Scripts/run-javascriptcore-tests: Allow testapi to run if we're in the AppleWinWebKit configuration. --- 2 files changed, 12 insertions(+), 1 deletions(-)
Adam Roben (:aroben)
Comment 5 2009-08-13 09:03:54 PDT
Fixed in r47199. http://trac.webkit.org/changeset/47199
Note You need to log in before you can comment on or make changes to this bug.