Bug 24854

Summary:

Rename PositionIterator members in hope of further clarity

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

HTML Editing

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, justin.garcia

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Rename PositionIterator members in hope of futher clarity	darin: review+
Rename PositionIterator::atStart/atEnd atStartOfTree/atEndOfTree	none
More cleanup and renaming to PositionIterator	none

Eric Seidel (no email)

Reported 2009-03-26 13:44:07 PDT

I'm going to make a bunch more small position cleanups today, before I start my 5th attempt to re-write positions. :) Hopefully these cleanups will continue to clarify and simplify the code, and continue to solidify my understanding of the mess that is position handling code. ;)

Attachments
Rename PositionIterator members in hope of futher clarity (10.31 KB, patch) 2009-03-26 13:51 PDT, Eric Seidel (no email)	darin: review+	Details Formatted Diff Diff
Rename PositionIterator::atStart/atEnd atStartOfTree/atEndOfTree (4.08 KB, patch) 2009-03-26 13:51 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
More cleanup and renaming to PositionIterator (15.34 KB, patch) 2009-03-26 15:31 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2009-03-26 13:51:14 PDT

Created attachment 28981 [details] Rename PositionIterator members in hope of futher clarity WebCore/ChangeLog | 28 ++++++++++ WebCore/dom/PositionIterator.cpp | 112 +++++++++++++++++++------------------- WebCore/dom/PositionIterator.h | 22 ++++---- 3 files changed, 95 insertions(+), 67 deletions(-)

Eric Seidel (no email)

Comment 2 2009-03-26 13:51:17 PDT

Created attachment 28982 [details] Rename PositionIterator::atStart/atEnd atStartOfTree/atEndOfTree WebCore/ChangeLog | 20 ++++++++++++++++++++ WebCore/dom/Position.cpp | 4 ++-- WebCore/dom/PositionIterator.cpp | 4 ++-- WebCore/dom/PositionIterator.h | 4 ++-- WebCore/editing/htmlediting.cpp | 4 ++-- 5 files changed, 28 insertions(+), 8 deletions(-)

Eric Seidel (no email)

Comment 3 2009-03-26 15:31:39 PDT

Comment on attachment 28982 [details] Rename PositionIterator::atStart/atEnd atStartOfTree/atEndOfTree Gonna remake this second patch to include more renames.

Eric Seidel (no email)

Comment 4 2009-03-26 15:31:56 PDT

Created attachment 28990 [details] More cleanup and renaming to PositionIterator WebCore/ChangeLog | 35 +++++++++++++- WebCore/dom/Position.cpp | 14 +++--- WebCore/dom/PositionIterator.cpp | 98 +++++++++++++++++++++++-------------- WebCore/dom/PositionIterator.h | 14 +++-- WebCore/editing/VisiblePosition.h | 5 ++ WebCore/editing/htmlediting.cpp | 4 +- 6 files changed, 118 insertions(+), 52 deletions(-)

Eric Seidel (no email)

Comment 5 2009-03-26 15:53:53 PDT

Comment on attachment 28990 [details] More cleanup and renaming to PositionIterator There is a missing return. Will upload fixed patch.

Maciej Stachowiak

Comment 6 2009-05-21 20:04:42 PDT

It would be good for someone familiar with PositionIterator such as Justin or Darin to chime in,

Darin Adler

Comment 7 2009-05-22 09:08:50 PDT

Comment on attachment 28981 [details] Rename PositionIterator members in hope of futher clarity I think "anchor" is a little vague, but the names seem fine here.

David Levin

Comment 8 2009-05-29 11:06:33 PDT

Assigned to Eric for landing his own patch.

Eric Seidel (no email)

Comment 9 2009-06-02 16:10:11 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/dom/PositionIterator.cpp M WebCore/dom/PositionIterator.h Committed r44374

Note You need to log in before you can comment on or make changes to this bug.