Summary: | Rename PositionIterator members in hope of further clarity | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||
Component: | HTML Editing | Assignee: | Eric Seidel (no email) <eric> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | darin, justin.garcia | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2009-03-26 13:44:07 PDT
Created attachment 28981 [details]
Rename PositionIterator members in hope of futher clarity
WebCore/ChangeLog | 28 ++++++++++
WebCore/dom/PositionIterator.cpp | 112 +++++++++++++++++++-------------------
WebCore/dom/PositionIterator.h | 22 ++++----
3 files changed, 95 insertions(+), 67 deletions(-)
Created attachment 28982 [details]
Rename PositionIterator::atStart/atEnd atStartOfTree/atEndOfTree
WebCore/ChangeLog | 20 ++++++++++++++++++++
WebCore/dom/Position.cpp | 4 ++--
WebCore/dom/PositionIterator.cpp | 4 ++--
WebCore/dom/PositionIterator.h | 4 ++--
WebCore/editing/htmlediting.cpp | 4 ++--
5 files changed, 28 insertions(+), 8 deletions(-)
Comment on attachment 28982 [details]
Rename PositionIterator::atStart/atEnd atStartOfTree/atEndOfTree
Gonna remake this second patch to include more renames.
Created attachment 28990 [details]
More cleanup and renaming to PositionIterator
WebCore/ChangeLog | 35 +++++++++++++-
WebCore/dom/Position.cpp | 14 +++---
WebCore/dom/PositionIterator.cpp | 98 +++++++++++++++++++++++--------------
WebCore/dom/PositionIterator.h | 14 +++--
WebCore/editing/VisiblePosition.h | 5 ++
WebCore/editing/htmlediting.cpp | 4 +-
6 files changed, 118 insertions(+), 52 deletions(-)
Comment on attachment 28990 [details]
More cleanup and renaming to PositionIterator
There is a missing return. Will upload fixed patch.
It would be good for someone familiar with PositionIterator such as Justin or Darin to chime in, Comment on attachment 28981 [details]
Rename PositionIterator members in hope of futher clarity
I think "anchor" is a little vague, but the names seem fine here.
Assigned to Eric for landing his own patch. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/dom/PositionIterator.cpp M WebCore/dom/PositionIterator.h Committed r44374 |