Bug 24852

Summary: Inconsistent flags might lead to link failure for ARM/RVCT release builds
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: carol, hausmann, norbert.leser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Revert change in PreloadScanner.cpp made by r40404 hausmann: review+

Description Laszlo Gombos 2009-03-26 13:37:39 PDT
Fix regression introduced by http://trac.webkit.org/changeset/40404.

During GNU mode RVCT compilation __GNUC__ is defined but COMPILER(GCC) is false. 

The output of gperf (HTMLEntityNames.c) generates code which will use the __GNUC__ flag; so PreloadScanner.cpp needs to use the __GNUC__ flag to stay consistent, otherwise GNU mode RVCT compilation will fail to link. 

The solution is to simply revert the change in PreloadScanner.cpp. 

Patch will follow.
Comment 1 Laszlo Gombos 2009-03-26 14:04:23 PDT
Created attachment 28985 [details]
Revert change in PreloadScanner.cpp made by r40404
Comment 2 Simon Hausmann 2009-03-27 06:05:04 PDT
Comment on attachment 28985 [details]
Revert change in PreloadScanner.cpp made by r40404

Looks good to me
Comment 3 Simon Hausmann 2009-03-27 06:05:23 PDT
Landed in r42036