Bug 248486
| Summary: | Potential crash fix by bailing from DeleteSelectionCommand::doApply when selection isn't editable | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I found another potential merge, which can make Webkit more stable and not hit situation leading to crash on debug or release builds:
Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=190121
Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/7e26ee98dc891f869c003c1724f061a82d65bd2b/Source/WebCore/editing/DeleteSelectionCommand.cpp#L984
This is to avoid any crash and harden the function.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
EWS
Committed 257203@main (b83027e6d7d0): <https://commits.webkit.org/257203@main>
Reviewed commits have been landed. Closing PR #6932 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/102835623>