Bug 248407
| Summary: | Fix Typo in WebGLRenderingContextBase.h for "texParameter" helper function | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | WebGL | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dino, kbr, kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink commit, I found another typo, which we still have and it would be good to fix.
Blink Commit - https://chromium.googlesource.com/chromium/blink/+/01e308688d652724afbc976dd1dbf6a37d662603
Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/1b6e6070bbb4454799b98ee84c5f0a72526b24f0/Source/WebCore/html/canvas/WebGLRenderingContextBase.h#LL1019
Here it is:
- void texParameter(GCGLenum target, GCGLenum pname, GCGLfloat parami, GCGLint paramf, bool isFloat);
+ void texParameter(GCGLenum target, GCGLenum pname, GCGLfloat paramf, GCGLint parami, bool isFloat);
It is fixed in Chromium / Blink - checked via source.chromium.org, just wanted to raise bug before fixing this. Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
EWS
Committed 257077@main (0af23318960c): <https://commits.webkit.org/257077@main>
Reviewed commits have been landed. Closing PR #6867 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/102723598>