Bug 248295

Summary: Remove WebPage::performDefaultBehaviorForKeyEvent
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: WebKit2Assignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, don.olmstead, kkinnunen, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Fujii Hironori
Reported 2022-11-23 17:34:13 PST
Remove WebPage::performDefaultBehaviorForKeyEvent 256929@main (bug#247949) added a code to EventHandler for keyboard scrolling. WinCairo was the last port using WebPage::performDefaultBehaviorForKeyEvent for keyboard scrolling. Removed it.
Attachments
Patch (8.93 KB, patch)
2022-11-23 17:37 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (9.13 KB, patch)
2022-11-24 16:41 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-11-23 17:37:14 PST
Created attachment 463700 [details] Patch
Fujii Hironori
Comment 2 2022-11-23 20:31:40 PST
Comment on attachment 463700 [details] Patch AppleWin EWS reported an regression. fast/dom/vertical-scrollbar-in-rtl.html [ Failure ]
Fujii Hironori
Comment 3 2022-11-24 16:41:59 PST
Created attachment 463721 [details] Patch
Fujii Hironori
Comment 4 2022-11-25 01:53:12 PST
Comment on attachment 463721 [details] Patch Thank you for the review.
EWS
Comment 5 2022-11-25 02:32:28 PST
Committed 257015@main (3ac7a6666750): <https://commits.webkit.org/257015@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463721 [details].
Radar WebKit Bug Importer
Comment 6 2022-11-25 02:33:18 PST
<rdar://problem/102662830>
Note You need to log in before you can comment on or make changes to this bug.