Bug 248191
| Summary: | Simplify TypingCommand::makeEditableRootEmpty() by removing firstElementChild | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink commits, I came across another potential simplification:
Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=180673
Webkit GitHub - https://github.com/WebKit/WebKit/blob/68c7e095336e350fb25defd9c5e2cb040a0764e2/Source/WebCore/editing/TypingCommand.cpp#L620
It will simplifies HTML editing code.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
EWS
Committed 256950@main (b78015aa9a05): <https://commits.webkit.org/256950@main>
Reviewed commits have been landed. Closing PR #6711 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/102612245>