Bug 248012
| Summary: | Update commit message template to request an explanation of why a PR fixes the bug | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | abifox, fujii.hironori, jbedard, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Kilzer (:ddkilzer)
Update commit message template to request a brief explanation of why a PR fixes the bug.
It's always easiest to explain what a patch does, but when reviewing a patch or looking at a previously committed patch, the most useful information that a commit message could contain is why (or how) the changes in the patch actually fix the bug.
Most folks already do this, so this just formalizes a placeholder for it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/102447501>
David Kilzer (:ddkilzer)
Pull request: https://github.com/apple/WebKit/pull/214
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/6579
Fujii Hironori
We have one more template there. https://github.com/WebKit/WebKit/blob/main/.github/pull_request_template.md
David Kilzer (:ddkilzer)
(In reply to Fujii Hironori from comment #4)
> We have one more template there.
> https://github.com/WebKit/WebKit/blob/main/.github/pull_request_template.md
Thanks! Updated the PR.
EWS
Committed 256835@main (0e7830380b81): <https://commits.webkit.org/256835@main>
Reviewed commits have been landed. Closing PR #6579 and removing active labels.