Bug 24797

Summary:

Improve wxWebKit keyboard shortcuts

Product:

WebKit

Reporter:

Diggilin <mr.diggilin>

Component:

WebKit wx

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
The Fix	none
Actually Working Fix	none
more complete keyboard shortcuts support	none
Moved shortcut => action map to shared location	kevino: review+

Diggilin

Reported 2009-03-25 01:26:30 PDT

wxWebKit cannot scroll with either the mouse wheel or keyboard.

Attachments
The Fix (9.04 KB, patch) 2009-03-25 01:30 PDT, Diggilin	no flags	Details Formatted Diff Diff
Actually Working Fix (15.51 KB, patch) 2009-03-25 22:40 PDT, Diggilin	no flags	Details Formatted Diff Diff
more complete keyboard shortcuts support (25.70 KB, patch) 2009-04-01 00:22 PDT, Diggilin	no flags	Details Formatted Diff Diff
Moved shortcut => action map to shared location (26.96 KB, patch) 2009-04-24 23:56 PDT, Diggilin	kevino: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Diggilin

Comment 1 2009-03-25 01:30:37 PDT

Created attachment 28926 [details] The Fix

Diggilin

Comment 2 2009-03-25 05:33:50 PDT

Don't commit first patch, I'll have a second one up tomorrow (GMT+8) that handles key scrolling properly (as in, after webkit has handled it).

Diggilin

Comment 3 2009-03-25 22:40:11 PDT

Created attachment 28963 [details] Actually Working Fix

Diggilin

Comment 4 2009-04-01 00:22:40 PDT

Created attachment 29156 [details] more complete keyboard shortcuts support This is complete and easier to extend. (with a big thanks to whoever designed the windows port's shortcuts)

Kevin Ollivier

Comment 5 2009-04-01 18:40:39 PDT

I think the bug summary is too limited for what this patch deals with, so I'm renaming it.

Kevin Ollivier

Comment 6 2009-04-05 12:10:40 PDT

Much of this patch is a straight copy and paste of the Windows code used to implement editing key events. As such, I'd rather move the Windows code up to some common location where both the Windows and wx ports can use it (and I suspect other ports will want to as well once it is available). Maybe in Editor? As this involves other ports, it would probably be good to bring this up on webkit-dev and ask. The idea would be that ports would not call these methods whenever they want to provide a different behavior, but otherwise they'd default to the behavior here. Once that's done, the only alteration that I think we would need to make would be to make isSystemKey a cross-platform method of PlatformKeyboardEvent, and in wx we'd have it always return false, even on Windows unfortunately because wx makes no distinction between a 'system' and 'non-system' key.

Diggilin

Comment 7 2009-04-24 23:56:53 PDT

Created attachment 29782 [details] Moved shortcut => action map to shared location

Kevin Ollivier

Comment 8 2009-05-05 17:51:52 PDT

Landed in r43265, thanks!

Note You need to log in before you can comment on or make changes to this bug.