| Summary: | Improve wxWebKit keyboard shortcuts | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Diggilin <mr.diggilin> | ||||||||||
| Component: | WebKit wx | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | ||||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Diggilin
2009-03-25 01:26:30 PDT
Created attachment 28926 [details]
The Fix
Don't commit first patch, I'll have a second one up tomorrow (GMT+8) that handles key scrolling properly (as in, after webkit has handled it). Created attachment 28963 [details]
Actually Working Fix
Created attachment 29156 [details]
more complete keyboard shortcuts support
This is complete and easier to extend. (with a big thanks to whoever designed the windows port's shortcuts)
I think the bug summary is too limited for what this patch deals with, so I'm renaming it. Much of this patch is a straight copy and paste of the Windows code used to implement editing key events. As such, I'd rather move the Windows code up to some common location where both the Windows and wx ports can use it (and I suspect other ports will want to as well once it is available). Maybe in Editor? As this involves other ports, it would probably be good to bring this up on webkit-dev and ask. The idea would be that ports would not call these methods whenever they want to provide a different behavior, but otherwise they'd default to the behavior here. Once that's done, the only alteration that I think we would need to make would be to make isSystemKey a cross-platform method of PlatformKeyboardEvent, and in wx we'd have it always return false, even on Windows unfortunately because wx makes no distinction between a 'system' and 'non-system' key. Created attachment 29782 [details]
Moved shortcut => action map to shared location
|