Bug 247900
| Summary: | Add support for skip-ews GitHub label | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, mark.lam, ryanhaddad, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=250859 | ||
Aakash Jain
Add support for Skip-EWS GitHub label. This label can be applied to a PR to skip EWS runs. There might be various scenarios in which people might want to apply such a label.
Foe e.g:
- Some engineers might want to abort EWS as soon as the they know that the change is going to be bad (e.g: an important ews on their patch failed, and they don't want to keep running on all other ewses).
- Someone just re-uploaded the change after doing a trivial change (add reviewer name, fix typo in PR title etc.)
- Admins wants to stop a bad PR (which might be breaking EWS bots) from further processing
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Aakash Jain
Note that, in bugzilla world, there are three ways to do similar thing:
1) r- the patch
2) mark the patch as obsolete from bugzilla UI
3) --no-ews while uploading the patch
In GitHub world, we don't have any way to do this.
Equivalent of r- in GitHub is marking the PR as Request changes, which still triggers the EWS. There is no way to mark a commit as obsolete in GitHub UI without uploading a new commit.
Aakash Jain
Pull request: https://github.com/WebKit/WebKit/pull/6476
EWS
Committed 256760@main (57ba798e7aa4): <https://commits.webkit.org/256760@main>
Reviewed commits have been landed. Closing PR #6476 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/102444473>
Jonathan Bedard
Re-opening for pull request https://github.com/apple/WebKit/pull/216
EWS
Committed 252432.837@safari-7614-branch (8dbf19696f48): <https://commits.webkit.org/252432.837@safari-7614-branch>
Reviewed commits have been landed. Closing PR #216 and removing active labels.