Bug 247856
| Summary: | Simplify includesAdjacentEdges in BorderEdge.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, ntim, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink commits, I came across another simplification / refactoring for "adjacency test" for Border Painting:
Blink Commit - https://chromium.googlesource.com/chromium/blink/+/45cd7b0546450187bb5f781d47778b739911341f
Webkit GitHub - https://github.com/WebKit/WebKit/blob/5a9504aef82d929917a680a05a3fc17f7f6b4dde/Source/WebCore/rendering/BorderEdge.h#L77
I am raising this bug so if this can be applied in Webkit context.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tim Nguyen (:ntim)
(In reply to Ahmad Saleem from comment #0)
> I am raising this bug so if this can be applied in Webkit context.
Yep, the equivalent would be:
flags.containsAny({ BoxSideFlag::Top, BoxSideFlag::Bottom })
&& flags.containsAny({ BoxSideFlag::Left, BoxSideFlag::Right })
Ahmad Saleem
https://github.com/WebKit/WebKit/pull/6445
EWS
Committed 256631@main (cf6c7427c391): <https://commits.webkit.org/256631@main>
Reviewed commits have been landed. Closing PR #6445 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/102302676>