Bug 247848
| Summary: | Making VisibleSelection operator== take base and extent into account | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, bfulgham, rniwa, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=199273 | ||
Ahmad Saleem
Hi Team,
While going through Blink Commits, I came across another interesting commit, which is something fixes long press text selections and dragging solution but it does not have any test case to validate the change.
Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=193950
Webkit GitHub - https://github.com/WebKit/WebKit/blob/50b63f352a0727a36aea7b4f380235a1048ffe7e/Source/WebCore/editing/VisibleSelection.h#L166
Since it does not have test case, I cannot verify whether we are still breaking something or not but if it can fix some edge cases of text selection and dragging (as it claims) then I think it would be good to consider.
Appreciate if someone can share insight into it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/102552348>
Ahmad Saleem
After discussing with rniwa, it seems that landing this without test case would not be ideal scenario and I would try to find relevant testcase to see how it affects us but as of right now, I would focus on other.
PR - https://github.com/WebKit/WebKit/pull/6563
Although we do have bugs around 'long press', 'drag', 'selection' and 'base and extent' in general. Thanks!
Ahmad Saleem
https://github.com/chromium/chromium/commit/31653763d678a148a511501aca73f8658efba143