Bug 247745
| Summary: | Setting -webkit-column-count to auto is the same as not setting it. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=247826 | ||
Ahmad Saleem
Hi Team,
I tried to look for similar bug but couldn't find and it is again based of another Blink commit:
Blink Commit - https://chromium.googlesource.com/chromium/blink/+/da85d1a90375fe50a92cf46f8a49571850618294
Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/fa2a14f12031baf24d5bc6d6727c3e25c5052589/Source/WebCore/rendering/style/RenderStyle.h#L1282
Test Case (Can't test) - https://jsfiddle.net/L35709ro/
Because it gives error - "There's no web exposed API usable for this test. The bug doesn't affect layout in a reliable way. Please rerun inside the layout test framework."
I am happy to do PR and fix it but would appreciate input of others. Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
I think the problem with this merge is that the test cases use internal APIs which are not present in Webkit.
I tried it here: https://github.com/WebKit/WebKit/pull/6368
FAIL internals.updateStyleAndReturnAffectedElementCount() should be 1. Threw exception TypeError: internals.updateStyleAndReturnAffectedElementCount is not a function. (In 'internals.updateStyleAndReturnAffectedElementCount()', 'internals.updateStyleAndReturnAffectedElementCount' is undefined)
FAIL internals.needsLayoutCount() should be 0. Threw exception TypeError: internals.needsLayoutCount is not a function. (In 'internals.needsLayoutCount()', 'internals.needsLayoutCount' is undefined)
____
Any solution would be appreciated. Thanks!
Ahmad Saleem
Close my PR with following comment:
"I have to close this bug because Webkit does not support "-webkit-columns: auto " properly and also don't have related Internals Webkit Testing Framework API to land this as it is. I have added first parsing bug as "See Also" while also explained the internal testing framework thing on the bug for future reference. Closing this now."
If we can land this without test case then it is good to go. Thanks!
EWS
Committed 256607@main (bc1d0765c50f): <https://commits.webkit.org/256607@main>
Reviewed commits have been landed. Closing PR #6368 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/102278097>