Bug 24765

Summary: prepare-ChangeLog and svn-create-patch doesn't work with svn 1.6
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, mitz, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
"Fix"
none
svn 1.6-only patch none

Anders Carlsson
Reported 2009-03-23 14:15:46 PDT
andersca1:WebKit andersca$ svn-create-patch svn: ' mac/Misc' is not a working copy svn: ' mac/Misc' does not exist svn: ' mac/Misc/WebKit.h' is not a working copy svn: ' mac/Misc/WebKit.h' does not exist andersca1:WebKit andersca$ pwd /Users/andersca/WebKit/OpenSource/WebKit Looks like an extra space was introduced somewhere in svn 1.6
Attachments
"Fix" (1.07 KB, patch)
2009-03-23 14:20 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
svn 1.6-only patch (1.25 KB, patch)
2009-03-23 14:21 PDT, mitz 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2009-03-23 14:16:59 PDT
andersca1:WebKit andersca$ svn diff Index: mac/Misc/WebKit.h =================================================================== --- mac/Misc/WebKit.h (revision 41917) +++ mac/Misc/WebKit.h (working copy) @@ -50,3 +50,4 @@ #import <WebKit/WebScriptObject.h> #import <WebKit/WebUIDelegate.h> #import <WebKit/WebView.h> + is the "patch"
mitz
Comment 2 2009-03-23 14:17:55 PDT
There's an additional status column in "svn status" output in svn 1.6.
Anders Carlsson
Comment 3 2009-03-23 14:20:56 PDT
Created attachment 28867 [details] "Fix" This fix makes it work with 1.6 only.
mitz
Comment 4 2009-03-23 14:21:07 PDT
Created attachment 28868 [details] svn 1.6-only patch These changes make the scripts work with svn 1.6 but break them for svn 1.5 and earlier
David Kilzer (:ddkilzer)
Comment 5 2009-03-29 16:08:45 PDT
Apparently this was fixed in r42053. http://trac.webkit.org/changeset/42053
David Kilzer (:ddkilzer)
Comment 6 2009-03-29 16:09:24 PDT
Maybe we can post the patch next time?
Note You need to log in before you can comment on or make changes to this bug.