Bug 247646
| Summary: | onorientationchange and orientation attributes must be present unconditionally even on platforms without orientation change | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> |
| Component: | DOM | Assignee: | Darin Adler <darin> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 253435 | ||
| Bug Blocks: | |||
Darin Adler
https://compat.spec.whatwg.org/#windoworientation-interface
Our implementation is only on platforms with an orientation concept, but the specification says it should be everywhere. That is straightforward to do.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/102110117>
Darin Adler
Pull request: https://github.com/WebKit/WebKit/pull/6269
EWS
Committed 256469@main (052d5b6a2ca0): <https://commits.webkit.org/256469@main>
Reviewed commits have been landed. Closing PR #6269 and removing active labels.
Chris Dumez
The spec (https://compat.spec.whatwg.org/#windoworientation-interface) says:
"User agents implementing the window.orientation attribute and its associated orientationchange event must not expose them on non-Mobile platforms."
Firefox and Chrome both don't expose this on Desktop. We have evidence of site breakage from this (rdar://106273441). I think we should revert.