Bug 247365
| Summary: | [Content Extensions] QueryTransforms should not unconditionally redirect to form-encoded URLs | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> |
| Component: | Platform | Assignee: | Wenson Hsieh <wenson_hsieh> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Wenson Hsieh
Currently, anything that passes through `RedirectAction::URLTransformAction::QueryTransform::applyToURL` gets unconditionally form-encoded (e.g. "=" -> "%20"), regardless of whether any rules actually matched.
This is because we always transform the query through `URLParser::parseURLEncodedForm`, and set the transformed URL query to the result, even if no parameters were removed/replaced/added.
For both performance and correctness, it probably makes sense to allow query parameters to pass through in their original form, if no rules matched.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Wenson Hsieh
Pull request: https://github.com/WebKit/WebKit/pull/6045
EWS
Committed 256260@main (b60c1a321a03): <https://commits.webkit.org/256260@main>
Reviewed commits have been landed. Closing PR #6045 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/101887185>