Bug 247274
| Summary: | We need git-webkit apply-pr and apply-from-bug | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
Ryosuke Niwa
webkit-patch has apply-attachment and apply-from-bug to apply patches posted on Bugzilla.
We need an equivalent command for applying PR and/or PR associated with the bug.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Note that one of important use cases is to apply PR written by someone else.
Alexey Proskuryakov
Arguably more important than it was in webkit-patch, because downloading a diff file from GitHub is an undiscoverable action.
Ryosuke Niwa
(In reply to Alexey Proskuryakov from comment #2)
> Arguably more important than it was in webkit-patch, because downloading a
> diff file from GitHub is an undiscoverable action.
Yeah, we used to able to download the diff on Bugzilla and apply that locally. Can't do that anymore either.
Alexey Proskuryakov
I should have explained how this undiscoverable action works. Adding .diff or .patch to a PR or commit link (like https://github.com/WebKit/WebKit/pull/5969.diff) produces downloadable diffs, either "git diff" or "git patch" style.
Radar WebKit Bug Importer
<rdar://problem/102048463>
Jonathan Bedard
`git-webkit checkout pr-#` exists, and is designed to solve this problem. If we wanted to expand this to bugs, we're basically resolving the pointer to the PR, then checking out the PR.