Bug 247239

Summary: [Live Range Selection] Expanding selection by granularity should expand anchor & focus
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, megan_gardner, mifenton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=218020
Bug Depends on:    
Bug Blocks: 216325    
Attachments:
Description Flags
WIP ews-feeder: commit-queue-

Ryosuke Niwa
Reported 2022-10-29 21:51:09 PDT
When expanding selection by non-character granularity, it should also affect anchor & focus.
Attachments
WIP (3.07 KB, patch)
2022-10-29 21:57 PDT, Ryosuke Niwa 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2022-10-29 21:57:18 PDT
Created attachment 463307 [details] WIP
Ryosuke Niwa
Comment 2 2022-10-29 22:06:23 PDT
The last test case in editing/selection/shift-click.html fails with this change. Need to look into that next week.
Radar WebKit Bug Importer
Comment 3 2022-10-29 22:06:45 PDT
<rdar://problem/101722271>
Ryosuke Niwa
Comment 4 2022-10-30 12:35:50 PDT
Comment on attachment 463307 [details] WIP Oh, this is interesting. The test failure goes away if I restore the old code in VisibleSelection::validate instead of new code in VisibleSelection::expandUsingGranularity.
Ryosuke Niwa
Comment 5 2022-10-30 14:22:24 PDT
Pull request: https://github.com/WebKit/WebKit/pull/5945
EWS
Comment 6 2022-10-31 16:40:12 PDT
Committed 256174@main (ca201a717c24): <https://commits.webkit.org/256174@main> Reviewed commits have been landed. Closing PR #5945 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.