Bug 247149 – WebSocket: Allow relative URLs and http(s) scheme

• Component: DOM
• Status: RESOLVED FIXED

See: https://github.com/whatwg/websockets/pull/37 & https://github.com/whatwg/websockets/issues/20

WIP patch: https://github.com/WebKit/WebKit/pull/5875

[Radar WebKit Bug Importer]

<rdar://problem/101929623>

[Alex Christensen]

This is significantly different than Firefox's approach.

I think Anne's comment "If we accept HTTP(S) schemes though we probably first want to normalize them to ws/wss, for the sake of consistency with the existing url getter" is interesting and should be considered.

Tests need updating.

(In reply to Alex Christensen from comment #2)
> This is significantly different than Firefox's approach.
> 
> I think Anne's comment "If we accept HTTP(S) schemes though we probably
> first want to normalize them to ws/wss, for the sake of consistency with the
> existing url getter" is interesting and should be considered.
> 
> Tests need updating.

I tested both against the same site and they behaved as expected, although slight deviations may exist? I have a pr against WPT which should help with ensuring things are working as expected. I don't know the exact processes but once that is merged I'll need help rolling wpt so this patch can be tested properly.

I thought it made more sense for the url getter to reflect the url that was passed in so it is not normalized. Do you feel strongly that it should be?

[Anne van Kesteren]

Pull request: https://github.com/WebKit/WebKit/pull/13751

[EWS]

Committed 263968@main (b5e7897d6636): <https://commits.webkit.org/263968@main>

Reviewed commits have been landed. Closing PR #13751 and removing active labels.