Bug 247092
| Summary: | [GTK4] GdkEvent should be managed by GRefPtr, not GUniquePtr | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | alicem, bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=247089 | ||
| Bug Depends on: | |||
| Bug Blocks: | 210100 | ||
Michael Catanzaro
In GTK 3, we use GUniquePtr to manage the lifetime of GdkEvents. But in GTK 4, we should switch to GRefPtr instead, rather than using a GUniquePtr that confusingly "deletes" the GdkEvent with gdk_event_unref().
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
Pull request: https://github.com/WebKit/WebKit/pull/5831
Michael Catanzaro
*** Bug 243290 has been marked as a duplicate of this bug. ***
EWS
Committed 256651@main (242c638012dd): <https://commits.webkit.org/256651@main>
Reviewed commits have been landed. Closing PR #5831 and removing active labels.