Bug 24705

Summary:

Can't set location.href in chromium

Product:

WebKit

Reporter:

Dave Moore <davemoore>

Component:

WebCore Misc.

Assignee:

David Levin <levin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

sam

Priority:

Version:

525.x (Safari 3.2)

Hardware:

OS:

All

Attachments:

Description	Flags
Patch	dglazkov: review+

Description Dave Moore 2009-03-19 16:26:52 PDT

A bug in the V8 bindings is preventing chromium from setting the href on the location object...any attempt throws a security error, not just for javascript protocols. See chromium bug http://code.google.com/p/chromium/issues/detail?id=8603

Comment 1 Dave Moore 2009-03-19 16:30:28 PDT

Created attachment 28770 [details]
Patch

Comment 2 Dimitri Glazkov (Google) 2009-03-20 09:17:08 PDT

Dave, can we possibly prefix this with V8, so that it's clear that this is a V8-specific modification. Also, I want to make sure Sam is ok with this. Adding him to cc.

Comment 3 Dave Moore 2009-03-20 09:26:13 PDT

I had it that way at one point, but Mike felt that it was better to do it without #ifdef'ing it

Comment 4 Sam Weinig 2009-03-20 12:44:12 PDT

Seems fine to me.  The CustomSetter clearly overrides this for JSC.

Comment 5 Dimitri Glazkov (Google) 2009-03-20 14:28:09 PDT

Gah. I didn't realize I wasn't on cc list.

Comment 6 David Levin 2009-03-20 16:00:00 PDT

Assigned to levin for landing.

Comment 7 David Levin 2009-03-20 16:57:51 PDT

Committed as r41882.