Bug 247034
| Summary: | [git-webkit] Deeply inspect potential gardening commits | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 246542 | ||
Jonathan Bedard
Gardening commits should not be considered "pickable." While we're pretty good at identifying commits as gardening commits, many of the strings used can also be used in legitimate commit messages. If we inspect the files changed in a commit, however, gardening commits become obvious. We can't performantly check all commits on a branch, but we can inspect every potential gardening commit.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/101568509>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/5789
EWS
Committed 256014@main (28f6affda692): <https://commits.webkit.org/256014@main>
Reviewed commits have been landed. Closing PR #5789 and removing active labels.
EWS
Committed 252432.685@safari-7614-branch (d93ba4173c65): <https://commits.webkit.org/252432.685@safari-7614-branch>
Reviewed commits have been landed. Closing PR #162 and removing active labels.