Bug 246957
| Summary: | [build.webkit.org] BuildAndTestAllButJSCFactory must forward parameters correctly to BuildAndTestFactory | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> |
| Component: | Tools / Tests | Assignee: | Lauro Moura <lmoura> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aakash_jain, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Lauro Moura
The initial version of https://github.com/WebKit/WebKit/pull/5710 added `additionalArguments` to a bunch of bots, including GTK-Linux-64-bit-Release-GTK4-Tests, which uses the BuildAndTestAllButJSCFactory, a subclass of BuildAndTestFactory.
This raised a failure in the build-webkit-org unittests with the extra steps when `triggers` is non-null added to the test output.
Turns out that BuildAndTestAllButJSCFactory wasn't forwarding the `triggers` parameter correctly to its parent class.
Originally `additionalArguments` was empty, and the test worked fine.
Patch incoming.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Lauro Moura
Pull request: https://github.com/WebKit/WebKit/pull/5729
EWS
Committed 255956@main (bb74e4622540): <https://commits.webkit.org/255956@main>
Reviewed commits have been landed. Closing PR #5729 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/101543208>