Bug 246747
| Summary: | [macOS] Fix absolute paths to macOS libraries in WebKit | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Elliott Williams <emw> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Elliott Williams
WebKit shouldn't be linking against libraries on the host system, it should always be using paths relative to the current SDKROOT. These dylib references need to be fixed:
https://github.com/WebKit/WebKit/blame/4fdd802cd89f9f7ecfb664cf9436f498bd7a4f51/Source/WebKit/Configurations/WebKit.xcconfig#L56 https://github.com/WebKit/WebKit/blame/4fdd802cd89f9f7ecfb664cf9436f498bd7a4f51/Source/WebKit/Configurations/WebKit.xcconfig#L167
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Elliott Williams
<rdar://problem/101228686>
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/5539
EWS
Committed 255751@main (de70c68258f5): <https://commits.webkit.org/255751@main>
Reviewed commits have been landed. Closing PR #5539 and removing active labels.