Bug 246718
| Summary: | [Xcode] Race condition when generating IDLFileNamesList.txt | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Elliott Williams <emw> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Elliott Williams
WebCore's DerivedSources.make generates this file once per invocation of preprocess-idls.pl:
$(IDL_INTERMEDIATE_PATTERNS) : …
$(shell echo $(JS_BINDING_IDLS) | tr " " "\n" > IDLFileNamesList.txt)
$(PERL) $(WebCore)/bindings/scripts/preprocess-idls.pl …
This can cause race conditions where proprocess-idls.pl is reading the list while another thread is regenerating it. We only need to generate it once, so this can be fixed by generating the list as a separate step.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/5516
EWS
Committed 255709@main (244ca6a14f4a): <https://commits.webkit.org/255709@main>
Reviewed commits have been landed. Closing PR #5516 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/101319105>