Bug 246638

Summary:

[leading-trim] Add support for parsing "leading-trim" CSS property

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, koivisto, kondapallykalyan, macpherson, menard, ntim, pdr, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

245599

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
[fast-cq]Patch	none

alan

Reported 2022-10-17 10:01:22 PDT

ssia

Attachments
Patch (11.48 KB, patch) 2022-10-17 10:04 PDT, alan	no flags	Details Formatted Diff Diff
Patch (13.85 KB, patch) 2022-11-27 16:12 PST, alan	no flags	Details Formatted Diff Diff
Patch (16.63 KB, patch) 2022-11-27 20:39 PST, alan	no flags	Details Formatted Diff Diff
[fast-cq]Patch (20.24 KB, patch) 2022-11-28 07:11 PST, alan	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2022-10-17 10:04:49 PDT

Created attachment 463035 [details] Patch

alan

Comment 2 2022-10-17 10:05:08 PDT

no tests yet.

Tim Nguyen (:ntim)

Comment 3 2022-10-17 10:36:16 PDT

Comment on attachment 463035 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463035&action=review > Source/WebCore/rendering/style/StyleRareNonInheritedData.h:250 > + unsigned leadingTrim : 3; // LeadingTrim This fits in 2

Tim Nguyen (:ntim)

Comment 4 2022-10-17 10:37:15 PDT

(Also, does this need a `settings-flag` field in CSSProperties.json and an associated preference?)

Antti Koivisto

Comment 5 2022-10-17 11:00:25 PDT

Comment on attachment 463035 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463035&action=review > Source/WebCore/css/CSSProperties.json:2959 > + "leading-trim": { > + "values": [ > + "normal", > + "start", > + "end", > + "both" > + ], > + "specification": { > + "category": "css-inline", > + "url": "https://www.w3.org/TR/css-inline-3/#leading-trim" > + } > + }, This should probably have a setting which can be given using "settings-flag" codegen option.

Antti Koivisto

Comment 6 2022-10-18 08:00:55 PDT

Comment on attachment 463035 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463035&action=review >> Source/WebCore/rendering/style/StyleRareNonInheritedData.h:250 >> + unsigned leadingTrim : 3; // LeadingTrim > > This fits in 2 You should initialise this field. It also needs to be present in the copy constructor and operator==.

Antti Koivisto

Comment 7 2022-10-18 08:06:29 PDT

Comment on attachment 463035 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=463035&action=review > Source/WebCore/css/CSSPrimitiveValueMappings.h:1089 > +template<> inline CSSPrimitiveValue::CSSPrimitiveValue(LeadingTrim e) "e" > Source/WebCore/css/CSSPrimitiveValueMappings.h:1106 > + break; > + } Could ASSERT_NOT_REACHED here

Radar WebKit Bug Importer

Comment 8 2022-10-24 10:02:20 PDT

<rdar://problem/101504835>

alan

Comment 9 2022-11-27 16:12:18 PST

Created attachment 463745 [details] Patch

alan

Comment 10 2022-11-27 20:39:42 PST

Created attachment 463748 [details] Patch

alan

Comment 11 2022-11-28 07:11:16 PST

Created attachment 463760 [details] [fast-cq]Patch

EWS

Comment 12 2022-11-28 07:33:00 PST

Committed 257070@main (8fe0bbfa84f9): <https://commits.webkit.org/257070@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463760 [details].

Note You need to log in before you can comment on or make changes to this bug.