Bug 24662

Summary:

Chromium build fixes.

Product:

WebKit

Reporter:

David Levin <levin>

Component:

Platform

Assignee:

David Levin <levin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed fix.	dglazkov: review+

Description David Levin 2009-03-17 18:33:33 PDT

These are various fixes that had to happen to make Chromium buildable.

Comment 1 David Levin 2009-03-17 18:39:20 PDT

Created attachment 28714 [details]
Proposed fix.

Comment 2 David Levin 2009-03-17 18:40:45 PDT

fyi I noticed a missing space in this line:
        SkRect topBorder = { rect.fLeft, rect.fTop, rect.width(), 1};
and added it locally.

Comment 3 Dimitri Glazkov (Google) 2009-03-17 20:28:33 PDT

Comment on attachment 28714 [details]
Proposed fix.

r=me.

Perhaps modify ChangeLog to have consistent reference to bug url. I like to use this format:

URL
Description

Comment 4 David Levin 2009-03-17 23:02:02 PDT

Committed as r41805.