Bug 246561
| Summary: | [WGSL] Prefix AST files to avoid name clashes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dan Glastonbury <djg> |
| Component: | WebGPU | Assignee: | Dan Glastonbury <djg> |
| Status: | RESOLVED FIXED | ||
| Severity: | Enhancement | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 246558 | ||
Dan Glastonbury
WebKit projects are built in Xcode using header maps, so each header file needs a unique name. WebGPU project has two headers named `ShaderModule.h`.
Since paths aren't used to disambiguate headers, I propose prefixing all WGSL AST node headers with `AST` and removing the nested directory structure.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/101198489>
Dan Glastonbury
Pull request: https://github.com/WebKit/WebKit/pull/5426
EWS
Committed 255614@main (2b6ef0c64240): <https://commits.webkit.org/255614@main>
Reviewed commits have been landed. Closing PR #5426 and removing active labels.