Summary: | Refactor RegisterSet to support 128-bit widths | ||
---|---|---|---|
Product: | WebKit | Reporter: | Justin Michaud <justin_michaud> |
Component: | JavaScriptCore | Assignee: | Michael Catanzaro <mcatanzaro> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | mcatanzaro, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Local Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=246588 |
Description
Justin Michaud
2022-10-13 16:33:06 PDT
Pull request: https://github.com/WebKit/WebKit/pull/5354 Committed 255583@main (a57d810b085e): <https://commits.webkit.org/255583@main> Reviewed commits have been landed. Closing PR #5354 and removing active labels. This was reverted in bug 246588 / 255596@main because of build breakage. Committed 255736@main (912bf24408b1): <https://commits.webkit.org/255736@main> Reviewed commits have been landed. Closing PR #5522 and removing active labels. This introduced a minor GCC warning spam, one warning for each unified source bundle that includes the header: [783/2475] Building CXX object Source/JavaScriptCore/CMak...vedSources/unified-sources/UnifiedSource-15db4ad9-4.cpp.o In file included from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmFormat.h:39, from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmCallee.h:33, from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmCalleeGroup.h:31, from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmModule.h:30, from /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/wasm/WasmModule.cpp:27, from /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk4/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-15db4ad9-4.cpp:2: /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk4/JavaScriptCore/DerivedSources/WasmOps.h: In member function ‘JSC::Width JSC::Wasm::Type::width() const’: /home/mcatanzaro/Projects/WebKit/WebKitBuild/gtk4/JavaScriptCore/DerivedSources/WasmOps.h:122:5: warning: control reaches end of non-void function [-Wreturn-type] 122 | } I will submit a follow-up. Oops, sorry! Re-opening for pull request https://github.com/WebKit/WebKit/pull/5555 Committed 255764@main (7bb3ebc2f29b): <https://commits.webkit.org/255764@main> Reviewed commits have been landed. Closing PR #5555 and removing active labels. Committed 257737@main (2d2f8ac6371b): <https://commits.webkit.org/257737@main> Reviewed commits have been landed. Closing PR #7487 and removing active labels. |