Bug 246478
| Summary: | Commit URLs causing 500 Internal Server Error | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | lingho <lingho> |
| Component: | WebKit Website | Assignee: | lingho <lingho> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | jond, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
lingho@apple.com
When a commit range URL in the form of "https://commits.webkit.org/compare/123456@main<ellipsis>234567@main" is entered into a comment, saving the comment, or subsequence comments causes bug page to return 500 Internal Server Error.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
lingho@apple.com
rdar://98541419
lingho@apple.com
Pull request: https://github.com/WebKit/WebKit/pull/5349
lingho@apple.com
The old regex was matching the 2nd commit ID, causing that part to be replaced with a URL, which in turn causing the 500 error.
The new regex should not match /123456@main and …123456@main and thus leave them alone.
lingho@apple.com
Updated title to cover another issue reported by Fujihori https://webkit.slack.com/archives/CU64U6FDW/p1664478835893709
where url such as this
https://commits.webkit.org/ + 252432.352@safari-7614-branch is causing issue.
EWS
Committed 255564@main (f59283656141): <https://commits.webkit.org/255564@main>
Reviewed commits have been landed. Closing PR #5349 and removing active labels.