Summary: | bisect-builds script doesn't work with Safari 4 Public Beta (version string) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben, mitz, mrowe | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2009-03-17 09:04:59 PDT
Created attachment 28693 [details]
Patch v1
This fixes bisect-builds with Safari 4 Public Beta.
The long-term fix is to switch from using "CFBundleShortVersionString" to using "CFBundleVersion" in findSafariVersion().
$ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bisect-builds Committed r41785 http://trac.webkit.org/changeset/41785 (In reply to comment #1) > The long-term fix is to switch from using "CFBundleShortVersionString" to using > "CFBundleVersion" in findSafariVersion(). See Bug 24652. |