Bug 246344
| Summary: | Correct autocorrect | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> |
| Component: | HTML Editing | Assignee: | Anne van Kesteren <annevk> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 151019 | ||
| Bug Blocks: | |||
Anne van Kesteren
For password/URL/email controls we do the wrong thing per https://github.com/web-platform-tests/wpt/pull/25073 and our proposed specification at https://github.com/whatwg/html/pull/5841.
Might want to wait with fixing this until the specification PR has landed.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/101036922>
Anne van Kesteren
Per recent specification discussion we'll also have to change isEmpty() to isNull() here:
bool HTMLFormControlElement::shouldAutocorrect() const
{
const AtomString& autocorrectValue = attributeWithoutSynchronization(autocorrectAttr);
if (!autocorrectValue.isEmpty())
return !equalLettersIgnoringASCIICase(autocorrectValue, "off"_s);
if (RefPtr<HTMLFormElement> form = this->form())
return form->shouldAutocorrect();
return true;
}
This causes an additional failure in the tests.
Anne van Kesteren
Pull request: https://github.com/WebKit/WebKit/pull/32388
EWS
Committed 282792@main (28a8a4b35f33): <https://commits.webkit.org/282792@main>
Reviewed commits have been landed. Closing PR #32388 and removing active labels.