Bug 246319

Summary:	encode Markable values without a separate isEmpty boolean
Product:	WebKit	Reporter:	Cameron McCormack (:heycam) <heycam>
Component:	Web Template Framework	Assignee:	Cameron McCormack (:heycam) <heycam>
Status:	RESOLVED WORKSFORME
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	246322

Cameron McCormack (:heycam)

Reported 2022-10-10 21:53:54 PDT

We currently encode Markable values by writing a bool first representing whether the value is the special empty value. We should make use of the fact that the types used in Markable are designed to represent an "is empty" state without additional storage.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-10-10 21:54:14 PDT

<rdar://problem/101014331>

Cameron McCormack (:heycam)

Comment 2 2022-10-10 22:40:30 PDT

Pull request: https://github.com/WebKit/WebKit/pull/5227

Cameron McCormack (:heycam)

Comment 3 2022-10-11 14:31:42 PDT

Decided against doing this.

Note You need to log in before you can comment on or make changes to this bug.