Bug 24630

Summary: Move and tweak BUILDING_ON_* macro defines (fixes wx build)
Product: WebKit Reporter: Kevin Ollivier <kevino>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Wx
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Moves and tweaks the BUILDING_ON_* macros to fix non-Apple builds
none
Updated patch that uses the Platform.h defines in WebKit/mac as well. mrowe: review+

Kevin Ollivier
Reported 2009-03-16 16:20:41 PDT
Currently the wx port is broken because the BUILDING_ON_* macros are defined in the *Prefix.h files on Mac, which are only used by XCode for the Apple Mac port. To fix this, I've moved the macros into Platform.h and updated the Mac port's JSCore and WebCore projects to pull them from there. For parts of the Mac port that do not use config.h / Platform.h, I've left the defines in the *Prefix.h header but updated them to match the ones defined in Platform.h.
Attachments
Moves and tweaks the BUILDING_ON_* macros to fix non-Apple builds (5.57 KB, patch)
2009-03-16 16:22 PDT, Kevin Ollivier 		no flags
DetailsFormatted DiffDiff
Updated patch that uses the Platform.h defines in WebKit/mac as well. (5.72 KB, patch)
2009-03-16 22:34 PDT, Kevin Ollivier 		mrowe: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kevin Ollivier
Comment 1 2009-03-16 16:22:12 PDT
Created attachment 28663 [details] Moves and tweaks the BUILDING_ON_* macros to fix non-Apple builds
Kevin Ollivier
Comment 2 2009-03-16 22:34:56 PDT
Created attachment 28677 [details] Updated patch that uses the Platform.h defines in WebKit/mac as well.
Mark Rowe (bdash)
Comment 3 2009-03-16 23:33:43 PDT
Comment on attachment 28677 [details] Updated patch that uses the Platform.h defines in WebKit/mac as well. r=me
Kevin Ollivier
Comment 4 2009-03-17 09:10:58 PDT
Landed in r41764, thanks!
Note You need to log in before you can comment on or make changes to this bug.