Bug 24625

Summary:

Accessor to the selected index needed in PopupMenuChromium

Product:

WebKit

Reporter:

Jay Campan <jcampan>

Component:

New Bugs

Assignee:

Jay Campan <jcampan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov

Priority:

Version:

420+

Hardware:

All

OS:

OS X 10.5

Attachments:

Description	Flags
Adds the selectedIndex accessor to PopupMenuChromium	dglazkov: review-
Fixed indent.	dglazkov: review+

Jay Campan

Reported 2009-03-16 13:07:55 PDT

In order to implement the deletion of autofill items in Chromium, PopupMenuChromium should have a getter to the selected index.

Attachments
Adds the selectedIndex accessor to PopupMenuChromium (1.82 KB, patch) 2009-03-16 13:11 PDT, Jay Campan	dglazkov: review-	Details Formatted Diff Diff
Fixed indent. (1.84 KB, patch) 2009-03-17 15:48 PDT, Jay Campan	dglazkov: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jay Campan

Comment 1 2009-03-16 13:11:00 PDT

Created attachment 28657 [details] Adds the selectedIndex accessor to PopupMenuChromium

Dimitri Glazkov (Google)

Comment 2 2009-03-17 15:38:09 PDT

Comment on attachment 28657 [details] Adds the selectedIndex accessor to PopupMenuChromium > +++ WebCore/platform/chromium/PopupMenuChromium.h (working copy) > @@ -107,6 +107,10 @@ namespace WebCore { > > PopupListBox* listBox() const { return m_listBox.get(); } > > + // Gets the index of the item that the user is currently moused-over or > + // has selected with the keyboard up/down arrows. > + int selectedIndex() const; > + ident fail? :)

Jay Campan

Comment 3 2009-03-17 15:48:29 PDT

Created attachment 28706 [details] Fixed indent.

Dimitri Glazkov (Google)

Comment 4 2009-03-17 15:51:30 PDT

Comment on attachment 28706 [details] Fixed indent. r=me. I'll land.

Dimitri Glazkov (Google)

Comment 5 2009-03-19 09:30:44 PDT

Landed as http://trac.webkit.org/changeset/41835.

Note You need to log in before you can comment on or make changes to this bug.