Bug 24625

Summary: Accessor to the selected index needed in PopupMenuChromium
Product: WebKit Reporter: Jay Campan <jcampan>
Component: New BugsAssignee: Jay Campan <jcampan>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov
Priority: P2    
Version: 420+   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Adds the selectedIndex accessor to PopupMenuChromium
dglazkov: review-
Fixed indent. dglazkov: review+

Description Jay Campan 2009-03-16 13:07:55 PDT
In order to implement the deletion of autofill items in Chromium, PopupMenuChromium should have a getter to the selected index.
Comment 1 Jay Campan 2009-03-16 13:11:00 PDT
Created attachment 28657 [details]
Adds the selectedIndex accessor to PopupMenuChromium
Comment 2 Dimitri Glazkov (Google) 2009-03-17 15:38:09 PDT
Comment on attachment 28657 [details]
Adds the selectedIndex accessor to PopupMenuChromium

> +++ WebCore/platform/chromium/PopupMenuChromium.h	(working copy)
> @@ -107,6 +107,10 @@ namespace WebCore {
>  
>          PopupListBox* listBox() const { return m_listBox.get(); }
>  
> +	// Gets the index of the item that the user is currently moused-over or
> +	// has selected with the keyboard up/down arrows.
> +	int selectedIndex() const;
> +

ident fail? :)
Comment 3 Jay Campan 2009-03-17 15:48:29 PDT
Created attachment 28706 [details]
Fixed indent.
Comment 4 Dimitri Glazkov (Google) 2009-03-17 15:51:30 PDT
Comment on attachment 28706 [details]
Fixed indent.

r=me. I'll land.
Comment 5 Dimitri Glazkov (Google) 2009-03-19 09:30:44 PDT
Landed as http://trac.webkit.org/changeset/41835.