Bug 245982

Summary:

[WinCairo] PageUp and PageDown keys don't start the smooth keyboard scrolling

Product:

WebKit

Reporter:

Fujii Hironori <fujii.hironori>

Component:

Platform

Assignee:

Fujii Hironori <fujii.hironori>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

basuke, destra, don.olmstead, ews-watchlist, mifenton, richard_robinson2, ross.kirsling, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP patch	none
Patch	none

Fujii Hironori

Reported 2022-10-03 14:49:37 PDT

[WinCairo] PageUp, PageDown, Home and End keys don't start keyboard scroll 255031@main (bug#228159) enabled EventHandlerDrivenSmoothKeyboardScrollingEnabled. It works nicely for Arrow keys, Space key and Shift+Space key, but for PageUp, PageDown, Home and End keys.

Attachments
WIP patch (2.34 KB, patch) 2022-10-03 21:51 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Patch (2.40 KB, patch) 2022-10-04 22:24 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2022-10-03 21:02:49 PDT

241197@main (bug#229733) fixed PageUp and PageDown for the smooth keyboard scrolling. But, 252663@main (bug#242523) removed the code. Mac port is using EditCommand (ScrollPageBackward and ScrollPageForward) for PageUp and PageDown now.

Fujii Hironori

Comment 2 2022-10-03 21:51:26 PDT

Created attachment 462779 [details] WIP patch

Fujii Hironori

Comment 3 2022-10-04 22:07:20 PDT

fast/dom/horizontal-scrollbar-in-rtl.html is failing for mac-wk2. I will split apart EditorCommand.cpp part into another patch.

Fujii Hironori

Comment 4 2022-10-04 22:24:37 PDT

Created attachment 462805 [details] Patch

Ross Kirsling

Comment 5 2022-10-05 00:22:58 PDT

Comment on attachment 462805 [details] Patch r=me