Bug 245945
| Summary: | Make "onpointerlockchange" & "onpointerlockerror" enumerable | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
I just noted that we are failing two tests in IDLHarness for "onpointerlockchange" & "onpointerlockerror":
Link - http://wpt.live/pointerlock/idlharness.window.html
It seems that it might be we are not following web-spec:
https://w3c.github.io/pointerlock/#extensions-to-the-document-interface
We have following:
https://github.com/WebKit/WebKit/blob/8afe31a018b11741abdf9b4d5bb973d7c1d9ff05/Source/WebCore/dom/Document%2BPointerLock.idl#L30
and we have "FIXME", I think (if not wrong) that making them "enumerable" will fix these tests as well
I was not able to find related bug so I create a new but if it is duplicate, please mark so.
Thanks
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Pull request: https://github.com/WebKit/WebKit/pull/4965
EWS
Committed 255153@main (9fb95a34c7e1): <https://commits.webkit.org/255153@main>
Reviewed commits have been landed. Closing PR #4965 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/100795827>