Bug 245929
| Summary: | Fix incorrectly positioned block element inside list-style-position:inside item | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://jsfiddle.net/745chzpy/show | ||
Ahmad Saleem
Hi Team,
It might be duplicate of other bugs but I want to try this bug by merging below and see how it goes.
Commit - https://chromium.googlesource.com/chromium/src/+/36d85fd5ae96048efcef076a209655ddf2bd02fe
Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/835b3f86b66bb2f7c66045c353a458a60d43800f/Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp#L111
_____
In case if I am not able to fix this, I will document my rationale etc. here.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/100933527>
Ahmad Saleem
I tried but I am not able to resolve build errors and not able to find "isInside" equivalent in Webkit (I might be wrong and trying it right):
https://github.com/WebKit/WebKit/pull/4900
Closing my PR for someone else to try.
alan
(In reply to Ahmad Saleem from comment #2)
> I tried but I am not able to resolve build errors and not able to find
> "isInside" equivalent in Webkit (I might be wrong and trying it right):
I think it maps to RenderListMarker::isInside
Ahmad Saleem
Latest PR attempt - https://github.com/WebKit/WebKit/pull/29373
It compiles and fixes last two failing CSS2 tests on WPT as well but it also lead to failing some legit WPT test:
Rebaseline - fast/repaint/list-marker.html
Legit failure - imported/w3c/web-platform-tests/css/css-lists/change-list-style-position-002.html
Closing PR for time being.
Ahmad Saleem
fixed with 296451@main.
*** This bug has been marked as a duplicate of bug 227000 ***