Bug 24583

Summary:

Need to change scope of constructor and destructor of V8ObjectEventListener from private to protected so that they could be used in its derived class V8WorkerContextEventListener.

Product:

WebKit

Reporter:

Jian Li <jianli>

Component:

WebCore Misc.

Assignee:

Dmitry Titov <dimich>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Patch	dglazkov: review+

Description Jian Li 2009-03-13 12:16:58 PDT

We need to change scope of constructor and destructor of V8ObjectEventListener from private to protected so that they could be used in its derived class V8WorkerContextEventListener.

Comment 1 Jian Li 2009-03-13 12:19:21 PDT

Created attachment 28590 [details]
Proposed Patch

Comment 2 Dimitri Glazkov (Google) 2009-03-13 13:35:47 PDT

Comment on attachment 28590 [details]
Proposed Patch

Yikes.

/me longs for the time when we will no longer be forked and produce these silly errors.

Comment 3 David Levin 2009-03-13 13:39:24 PDT

Assign to levin for landing.

Comment 4 Dmitry Titov 2009-03-13 13:40:55 PDT

reassigning to me for landing.

Comment 5 Dmitry Titov 2009-03-13 13:47:07 PDT

landed in http://trac.webkit.org/changeset/41682