Bug 245742
| Summary: | [webkit-patch] Parse non-utf characters | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | rreno, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jonathan Bedard
When we are parsing patches and diffs, we should at least not crash when parsing non-utf characters, even if we can't accurately display or reason about such characters.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/100466774>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/4759
Jonathan Bedard
For posterity's sake, would like to address something brought up in a Slack thread about this change.
It would be possible to make our style checker and commit message builder operate on bytes instead of strings, which would avoid needing to replace non UTF-8 characters, however, that would require pretty extensive changes to our style checker code. Given that we don't really expect lines with non UTF-8 characters to be handled correctly in the style checker anyways, replacing them so we can at least run the style checker over files with non UTF-8 characters seems prudent.
EWS
Committed 254967@main (cd13c6e5c9e2): <https://commits.webkit.org/254967@main>
Reviewed commits have been landed. Closing PR #4759 and removing active labels.
Ryan Reno
*** Bug 245690 has been marked as a duplicate of this bug. ***
Jonathan Bedard
Re-opening for pull request https://github.com/WebKit/WebKit/pull/4834
EWS
Committed 257761@main (3c2f6580b5c3): <https://commits.webkit.org/257761@main>
Reviewed commits have been landed. Closing PR #4834 and removing active labels.