Bug 245690
| Summary: | string_utils decoder assumes UTF-8 and can crash when encountering other encodings. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Reno <rreno> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | ap, jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryan Reno
The Micro sign in latin-1 is encoded differently from UTF-8. The Python UTF-8 codec fails if it encounters this symbol because we assume by default UTF-8. In particular, I've encountered the failure when the commit message generator and style checker tools are trying to parse https://github.com/web-platform-tests/wpt/blob/master/content-security-policy/script-src/hash-always-converted-to-utf-8/iso-8859-1.html#L13 on import (LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/hash-always-converted-to-utf-8/iso-8859-1.html).
This causes crashes due to an unhandled UnicodeDecodeError in our string_utils decoder implementation.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/100423966>
Alexey Proskuryakov
Is this what 254967@main fixed? Not entirely sure of the context in this bug.
Ryan Reno
(In reply to Alexey Proskuryakov from comment #2)
> Is this what 254967@main fixed? Not entirely sure of the context in this bug.
Yes.
*** This bug has been marked as a duplicate of bug 245742 ***