Bug 24557

Summary: Add locker to v8 event listener of worker context.
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore Misc.Assignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Patch
dglazkov: review+
Proposed Patch dglazkov: review+

Jian Li
Reported 2009-03-12 13:46:59 PDT
Add locker to v8 event listener of worker context.
Attachments
Proposed Patch (1.15 KB, patch)
2009-03-12 13:50 PDT, Jian Li 		dglazkov: review+
DetailsFormatted DiffDiff
Proposed Patch (1.22 KB, patch)
2009-03-13 10:10 PDT, Jian Li 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2009-03-12 13:50:07 PDT
Created attachment 28548 [details] Proposed Patch
Dimitri Glazkov (Google)
Comment 2 2009-03-13 09:35:09 PDT
Comment on attachment 28548 [details] Proposed Patch > + Bug 24557: Add locker to v8 event listener of worker context. > + https://bugs.webkit.org/show_bug.cgi?id=24557 This is probably more conventional and less redundant: https://bugs.webkit.org/show_bug.cgi?id=24557 Add locker to v8 event listener of worker context. Also, perhaps we could make the comment a little bit more informative? It sounds more like a description an action rather than the problem it aims to solve.
Jian Li
Comment 3 2009-03-13 10:10:52 PDT
Created attachment 28579 [details] Proposed Patch
Dimitri Glazkov (Google)
Comment 4 2009-03-13 10:20:00 PDT
Comment on attachment 28579 [details] Proposed Patch I see you didn't take my first suggestion :). r=me, just try to make ChangeLog entries consistent with others'. Also, the "Add locker to v8 event listener of worker context" probably belongs with + (WebCore::V8WorkerContextEventListener::handleEvent):
David Levin
Comment 5 2009-03-13 10:21:21 PDT
Assigned to levin for landing.
David Levin
Comment 6 2009-03-13 10:34:03 PDT
Committed in r41670.
Note You need to log in before you can comment on or make changes to this bug.