|Summary:||Add locker to v8 event listener of worker context.|
|Product:||WebKit||Reporter:||Jian Li <jianli>|
|Component:||WebCore Misc.||Assignee:||David Levin <levin>|
|Version:||528+ (Nightly build)|
Description Jian Li 2009-03-12 13:46:59 PDT
Add locker to v8 event listener of worker context.
Comment 2 Dimitri Glazkov (Google) 2009-03-13 09:35:09 PDT
Comment on attachment 28548 [details] Proposed Patch > + Bug 24557: Add locker to v8 event listener of worker context. > + https://bugs.webkit.org/show_bug.cgi?id=24557 This is probably more conventional and less redundant: https://bugs.webkit.org/show_bug.cgi?id=24557 Add locker to v8 event listener of worker context. Also, perhaps we could make the comment a little bit more informative? It sounds more like a description an action rather than the problem it aims to solve.
Comment 4 Dimitri Glazkov (Google) 2009-03-13 10:20:00 PDT
Comment on attachment 28579 [details] Proposed Patch I see you didn't take my first suggestion :). r=me, just try to make ChangeLog entries consistent with others'. Also, the "Add locker to v8 event listener of worker context" probably belongs with + (WebCore::V8WorkerContextEventListener::handleEvent):
Comment 5 David Levin 2009-03-13 10:21:21 PDT
Assigned to levin for landing.