Bug 24553

Summary:

[GTK] Improvements to WebKitDownload

Product:

WebKit

Reporter:

Gustavo Noronha (kov) <gustavo>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Gtk

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
the doc fix	ap: review+
rename state to status and make it a property	ap: review+

Gustavo Noronha (kov)

Reported 2009-03-12 11:56:22 PDT

We need a small documentation fix for the download-requested signal, and we decided to rename state to 'status', and make it a property, to match the frame loader signals rework we plan to land soonish (https://bugs.webkit.org/show_bug.cgi?id=17066).

Attachments
the doc fix (2.25 KB, patch) 2009-03-12 11:56 PDT, Gustavo Noronha (kov)	ap: review+	Details Formatted Diff Diff
rename state to status and make it a property (11.78 KB, patch) 2009-03-12 11:57 PDT, Gustavo Noronha (kov)	ap: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gustavo Noronha (kov)

Comment 1 2009-03-12 11:56:49 PDT

Created attachment 28537 [details] the doc fix

Gustavo Noronha (kov)

Comment 2 2009-03-12 11:57:19 PDT

Created attachment 28538 [details] rename state to status and make it a property

Gustavo Noronha (kov)

Comment 3 2009-03-12 11:57:55 PDT

I've adapted the download support in Epiphany to these changes and Epiphany keeps working perfectly.

Alexey Proskuryakov

Comment 4 2009-03-12 12:11:31 PDT

Comment on attachment 28537 [details] the doc fix r=me

Alexey Proskuryakov

Comment 5 2009-03-12 12:15:38 PDT

Comment on attachment 28538 [details] rename state to status and make it a property Looks fine, r=me

Gustavo Noronha (kov)

Comment 6 2009-03-12 12:33:32 PDT

Landed as r41638 and r41639.

Note You need to log in before you can comment on or make changes to this bug.