Bug 24553

Summary: [GTK] Improvements to WebKitDownload
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
the doc fix
ap: review+
rename state to status and make it a property ap: review+

Description Gustavo Noronha (kov) 2009-03-12 11:56:22 PDT
We need a small documentation fix for the download-requested signal, and we decided to rename state to 'status', and make it a property, to match the frame loader signals rework we plan to land soonish (https://bugs.webkit.org/show_bug.cgi?id=17066).
Comment 1 Gustavo Noronha (kov) 2009-03-12 11:56:49 PDT
Created attachment 28537 [details]
the doc fix
Comment 2 Gustavo Noronha (kov) 2009-03-12 11:57:19 PDT
Created attachment 28538 [details]
rename state to status and make it a property
Comment 3 Gustavo Noronha (kov) 2009-03-12 11:57:55 PDT
I've adapted the download support in Epiphany to these changes and Epiphany keeps working perfectly.
Comment 4 Alexey Proskuryakov 2009-03-12 12:11:31 PDT
Comment on attachment 28537 [details]
the doc fix

r=me
Comment 5 Alexey Proskuryakov 2009-03-12 12:15:38 PDT
Comment on attachment 28538 [details]
rename state to status and make it a property

Looks fine, r=me
Comment 6 Gustavo Noronha (kov) 2009-03-12 12:33:32 PDT
Landed as r41638 and r41639.