Bug 24543
| Summary: | Rename KURL::isLocalFile() to isFileURL() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Julien Chaffraix <jchaffraix> |
| Component: | WebCore Misc. | Assignee: | Julien Chaffraix <jchaffraix> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | annevk, ap, darin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Julien Chaffraix
This was raised during bug 22475.
To sum up what was said, isLocalFile is not totally right as the resource can be remote but mounted in the local filesystem. isFileURL would be more appropriate and stick to what the method is currently doing.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Julien Chaffraix
Darin, could you tell us your thoughts about this renaming?
Darin Adler
Seems OK.
I don't like the idea of repeating the class name, URL, in the function. Maybe it should be protocolIsFile to be a member of the "protocol" family of functions. If so, then it would be good to have a version that works on strings too, just like protocolIs. And have protocolIsJavaScript too.
Anne van Kesteren
*** This bug has been marked as a duplicate of bug 257316 ***