Scrolling with home and end keys not always works

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Gustavo Noronha (kov)]

Pressing the home and end keys not always work, and some times doesn't scroll to the beginning/end of the page. Try opening this page, click the view, click the down arrow, then click home, for instance.

[Gustavo Noronha (kov)]

Created attachment 28519 [details]
proposed fix

[Gustavo Noronha (kov)]

I found that on some sites, such as orkut, pgdown/pgup also do not work at all. I'll add another patch for that here.

[Gustavo Noronha (kov)]

Created attachment 28528 [details]
also make this work correctly for page up/down

If you want to test the problem/fix use the bugzilla review page. The top frame doesn't scroll correctly with pgup/down.

[Alp Toker]

Comment on attachment 28528 [details]
also make this work correctly for page up/down

r=me

Hope we'll tidy up the keypress/scrolling code soon though.

[Alp Toker]

Comment on attachment 28519 [details]
proposed fix

r=me

Will do until this code is cleaned up to get the basic functionality.

[Gustavo Noronha (kov)]

(In reply to comment #4)
> (From update of attachment 28528 [details] [review])
> r=me
> 
> Hope we'll tidy up the keypress/scrolling code soon though.
> 

Yeah, like I said in the spacebar bug, and on IRC, I think we need to review scrolling as a whole for the GTK+ port. I'd like to start that by implementing Scrollview::scroll. Time allowing, I'll do it.

[Gustavo Noronha (kov)]

Landed as r41624 and r41625.