|Summary:||Build failure - tzname name conflict|
|Product:||WebKit||Reporter:||Norbert Leser <norbert.leser>|
|Version:||528+ (Nightly build)|
|OS:||S60 3rd edition|
|Bug Depends on:|
Description Norbert Leser 2009-03-11 19:23:18 PDT
In implementation of DateMath class is a name conflict with globally defined tzname in Symbian. The proposed solution is to replace the "tzname" with different name instead of using namespace qualifier (appeared to be less clumsy). Similarly, there doesn't appear to be any reason for a conditional change. See attached patch.
Comment 1 Norbert Leser 2009-03-11 19:24:06 PDT
Created attachment 28513 [details] Proposed fix for bug 24537
Comment 2 Mark Rowe (bdash) 2009-03-11 19:27:13 PDT
The patch does a lot more than renaming tzname, even though that is all the changelog mentions. That's a bit misleading.
Comment 3 Mark Rowe (bdash) 2009-03-11 19:36:14 PDT
Your changelogs should also have a name rather than "Nokia User".
Comment 4 Norbert Leser 2009-03-12 08:10:23 PDT
(In reply to comment #2) > The patch does a lot more than renaming tzname, even though that is all the > changelog mentions. That's a bit misleading. > The patch has 1 more (not a lot more) changes, which is PLATFORM(SYMBIAN) conditional stuff related to DST processing. You're right, it should not have been munched together. I will separate it, update the patch and submit the symbian related stuff as a new bug report.
Comment 5 Norbert Leser 2009-03-13 10:29:03 PDT
Created attachment 28583 [details] Patch update for 24537 As discussed, I removed the SYMBIAN conditional changes from this change request (will file that at a later point separately). This new patch contains the renaming of "tzname" only.
Comment 6 Darin Adler 2009-03-13 12:16:00 PDT
Comment on attachment 28583 [details] Patch update for 24537 Seems OK. But if I had to change this, I'd prefer to change it to something less cryptic rather than more. Like timeZoneName, rather than tznm. r=me
Comment 7 Norbert Leser 2009-03-13 12:27:13 PDT
(In reply to comment #6) > (From update of attachment 28583 [details] [review]) > Seems OK. But if I had to change this, I'd prefer to change it to something > less cryptic rather than more. Like timeZoneName, rather than tznm. > > r=me > Sure, I don't mind verbose names. Do you need another patch or can you fix that directly?