Bug 24531

Summary: Crash clicking around on animation-rich site
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch, changelog
none
Revised patch darin: review+

Simon Fraser (smfr)
Reported 2009-03-11 17:29:08 PDT
I got a crash in RenderLayer::currentTransform() when clicking around on an animation-heavy site (Apple internal).
Attachments
Patch, changelog (4.04 KB, patch)
2009-03-11 17:33 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Revised patch (1.89 KB, patch)
2009-03-11 17:46 PDT, Simon Fraser (smfr) 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2009-03-11 17:29:34 PDT
The problem is that getAnimatedStyleForRenderer() can return a null style, and is not expected to.
Simon Fraser (smfr)
Comment 2 2009-03-11 17:33:05 PDT
Created attachment 28504 [details] Patch, changelog A testcase is hard, because it requires fast clicking.
Darin Adler
Comment 3 2009-03-11 17:35:58 PDT
Comment on attachment 28504 [details] Patch, changelog Seems to me we could have just done this in AnimationControllerPrivate::getAnimatedStyleForRenderer and avoided passing that renderer down all those levels. Would that be better?
Simon Fraser (smfr)
Comment 4 2009-03-11 17:42:32 PDT
Darin: I did it this way to avoid another RefPtr<RenderStyle> in getAnimatedStyleForRenderer(). But I can do it that way if you like.
Simon Fraser (smfr)
Comment 5 2009-03-11 17:46:07 PDT
Created attachment 28506 [details] Revised patch
Darin Adler
Comment 6 2009-03-11 17:48:24 PDT
Comment on attachment 28506 [details] Revised patch Seems way better. Don't forget to fix the change log to only mention the one file you changed. r=me
Simon Fraser (smfr)
Comment 7 2009-03-11 17:52:24 PDT
Fixed changelog. http://trac.webkit.org/changeset/41603
Note You need to log in before you can comment on or make changes to this bug.