Bug 24531

Summary: Crash clicking around on animation-rich site
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch, changelog
none
Revised patch darin: review+

Description Simon Fraser (smfr) 2009-03-11 17:29:08 PDT 
I got a crash in RenderLayer::currentTransform() when clicking around on an animation-heavy site (Apple internal).
Comment 1 Simon Fraser (smfr) 2009-03-11 17:29:34 PDT 
The problem is that getAnimatedStyleForRenderer() can return a null style, and is not expected to.
Comment 2 Simon Fraser (smfr) 2009-03-11 17:33:05 PDT 
Created attachment 28504 [details]
Patch, changelog

A testcase is hard, because it requires fast clicking.
Comment 3 Darin Adler 2009-03-11 17:35:58 PDT 
Comment on attachment 28504 [details]
Patch, changelog

Seems to me we could have just done this in AnimationControllerPrivate::getAnimatedStyleForRenderer and avoided passing that renderer down all those levels. Would that be better?
Comment 4 Simon Fraser (smfr) 2009-03-11 17:42:32 PDT 
Darin: I did it this way to avoid another RefPtr<RenderStyle> in getAnimatedStyleForRenderer(). But I can do it that way if you like.
Comment 5 Simon Fraser (smfr) 2009-03-11 17:46:07 PDT 
Created attachment 28506 [details]
Revised patch
Comment 6 Darin Adler 2009-03-11 17:48:24 PDT 
Comment on attachment 28506 [details]
Revised patch

Seems way better.

Don't forget to fix the change log to only mention the one file you changed.

r=me
Comment 7 Simon Fraser (smfr) 2009-03-11 17:52:24 PDT 
Fixed changelog.

http://trac.webkit.org/changeset/41603