Bug 24531 - Crash clicking around on animation-rich site
Summary: Crash clicking around on animation-rich site
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-11 17:29 PDT by Simon Fraser (smfr)
Modified: 2009-03-11 17:52 PDT (History)
2 users (show)

See Also:

Attachments
Patch, changelog (4.04 KB, patch)
2009-03-11 17:33 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Revised patch (1.89 KB, patch)
2009-03-11 17:46 PDT, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-03-11 17:29:08 PDT 
I got a crash in RenderLayer::currentTransform() when clicking around on an animation-heavy site (Apple internal).
Comment 1 Simon Fraser (smfr) 2009-03-11 17:29:34 PDT 
The problem is that getAnimatedStyleForRenderer() can return a null style, and is not expected to.
Comment 2 Simon Fraser (smfr) 2009-03-11 17:33:05 PDT 
Created attachment 28504 [details]
Patch, changelog

A testcase is hard, because it requires fast clicking.
Comment 3 Darin Adler 2009-03-11 17:35:58 PDT 
Comment on attachment 28504 [details]
Patch, changelog

Seems to me we could have just done this in AnimationControllerPrivate::getAnimatedStyleForRenderer and avoided passing that renderer down all those levels. Would that be better?
Comment 4 Simon Fraser (smfr) 2009-03-11 17:42:32 PDT 
Darin: I did it this way to avoid another RefPtr<RenderStyle> in getAnimatedStyleForRenderer(). But I can do it that way if you like.
Comment 5 Simon Fraser (smfr) 2009-03-11 17:46:07 PDT 
Created attachment 28506 [details]
Revised patch
Comment 6 Darin Adler 2009-03-11 17:48:24 PDT 
Comment on attachment 28506 [details]
Revised patch

Seems way better.

Don't forget to fix the change log to only mention the one file you changed.

r=me
Comment 7 Simon Fraser (smfr) 2009-03-11 17:52:24 PDT 
Fixed changelog.

http://trac.webkit.org/changeset/41603