Bug 24520

Summary: Add test cases to check lookup precedence of DOM constructors
Product: WebKit Reporter: Pam Greene (IRC:pamg) <pam>
Component: DOMAssignee: Pam Greene (IRC:pamg) <pam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Modified test + new results
none
Test for name too ap: review+

Pam Greene (IRC:pamg)
Reported 2009-03-11 14:01:59 PDT
Make sure DOM constructors have higher lookup precedence than a document element with the same name.
Attachments
Modified test + new results (4.21 KB, patch)
2009-03-11 14:04 PDT, Pam Greene (IRC:pamg) 		no flags
DetailsFormatted DiffDiff
Test for name too (5.11 KB, patch)
2009-03-12 12:56 PDT, Pam Greene (IRC:pamg) 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pam Greene (IRC:pamg)
Comment 1 2009-03-11 14:04:31 PDT
Created attachment 28490 [details] Modified test + new results
Alexey Proskuryakov
Comment 2 2009-03-12 01:16:32 PDT
Comment on attachment 28490 [details] Modified test + new results > + Add test cases to ensure that DOM constructors have higher lookup > + precedence than a document element with the same name. The test uses id, not name - is that intentional? Should it test both?
Pam Greene (IRC:pamg)
Comment 3 2009-03-12 12:56:34 PDT
Created attachment 28543 [details] Test for name too ID is the case that had a problem (http://code.google.com/p/v8/issues/detail?id=43), but sure, let's test name too.
Alexey Proskuryakov
Comment 4 2009-03-13 03:46:10 PDT
Comment on attachment 28543 [details] Test for name too r=me, assuming that the new results match Firefox.
Pam Greene (IRC:pamg)
Comment 5 2009-03-13 10:10:20 PDT
WebKit and Firefox don't match in their previously tested behavior: WebKit has constructors for several objects that Firefox doesn't. So FF fails some cases in this test, but no new failures show up due to these test-case additions. That is, in those cases where FF has a constructor at all, its lookup precedence matches ours. Landed as r41669.
Note You need to log in before you can comment on or make changes to this bug.